Переглянути джерело

drm/i915/overlay: Missing breaks between case statements for color depth

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Chris Wilson 15 роки тому
батько
коміт
6ba3ddd983
1 змінених файлів з 6 додано та 0 видалено
  1. 6 0
      drivers/gpu/drm/i915/intel_overlay.c

+ 6 - 0
drivers/gpu/drm/i915/intel_overlay.c

@@ -675,10 +675,13 @@ static void update_colorkey(struct intel_overlay *overlay,
 			    struct overlay_registers *regs)
 			    struct overlay_registers *regs)
 {
 {
 	u32 key = overlay->color_key;
 	u32 key = overlay->color_key;
+
 	switch (overlay->crtc->base.fb->bits_per_pixel) {
 	switch (overlay->crtc->base.fb->bits_per_pixel) {
 	case 8:
 	case 8:
 		regs->DCLRKV = 0;
 		regs->DCLRKV = 0;
 		regs->DCLRKM = CLK_RGB8I_MASK | DST_KEY_ENABLE;
 		regs->DCLRKM = CLK_RGB8I_MASK | DST_KEY_ENABLE;
+		break;
+
 	case 16:
 	case 16:
 		if (overlay->crtc->base.fb->depth == 15) {
 		if (overlay->crtc->base.fb->depth == 15) {
 			regs->DCLRKV = RGB15_TO_COLORKEY(key);
 			regs->DCLRKV = RGB15_TO_COLORKEY(key);
@@ -687,10 +690,13 @@ static void update_colorkey(struct intel_overlay *overlay,
 			regs->DCLRKV = RGB16_TO_COLORKEY(key);
 			regs->DCLRKV = RGB16_TO_COLORKEY(key);
 			regs->DCLRKM = CLK_RGB16_MASK | DST_KEY_ENABLE;
 			regs->DCLRKM = CLK_RGB16_MASK | DST_KEY_ENABLE;
 		}
 		}
+		break;
+
 	case 24:
 	case 24:
 	case 32:
 	case 32:
 		regs->DCLRKV = key;
 		regs->DCLRKV = key;
 		regs->DCLRKM = CLK_RGB24_MASK | DST_KEY_ENABLE;
 		regs->DCLRKM = CLK_RGB24_MASK | DST_KEY_ENABLE;
+		break;
 	}
 	}
 }
 }