Browse Source

OMAP3+: voltage: update nominal voltage in voltdm_scale() not VC post-scale

Currently, the nominal voltage is updated in the VC post-scale function
which is common to both scaling methods.  However, this has readabiliy
problems as this update is not where it might be expected.  Instead, move
the updated into voltdm_scale() upon a successful return of voltdm->scale()

Signed-off-by: Kevin Hilman <khilman@ti.com>
Kevin Hilman 14 years ago
parent
commit
6a62b78d9a
2 changed files with 5 additions and 3 deletions
  1. 0 2
      arch/arm/mach-omap2/vc.c
  2. 5 1
      arch/arm/mach-omap2/voltage.c

+ 0 - 2
arch/arm/mach-omap2/vc.c

@@ -152,8 +152,6 @@ void omap_vc_post_scale(struct voltagedomain *voltdm,
 	smps_delay = ((smps_steps * voltdm->pmic->step_size) /
 			voltdm->pmic->slew_rate) + 2;
 	udelay(smps_delay);
-
-	voltdm->nominal_volt = target_volt;
 }
 
 /* vc_bypass_scale - VC bypass method of voltage scaling */

+ 5 - 1
arch/arm/mach-omap2/voltage.c

@@ -85,7 +85,11 @@ int voltdm_scale(struct voltagedomain *voltdm,
 		return -ENODATA;
 	}
 
-	return voltdm->scale(voltdm, target_volt);
+	ret = voltdm->scale(voltdm, target_volt);
+	if (!ret)
+		voltdm->nominal_volt = target_volt;
+
+	return ret;
 }
 
 /**