Przeglądaj źródła

[PATCH] cpuset: minor code refinements

A couple of minor code simplifications to the kernel/cpuset.c code.  No
functional change.  Just a little less code and a little more readable.

Signed-off-by: Paul Jackson <pj@sgi.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Paul Jackson 18 lat temu
rodzic
commit
696040670a
1 zmienionych plików z 4 dodań i 5 usunięć
  1. 4 5
      kernel/cpuset.c

+ 4 - 5
kernel/cpuset.c

@@ -729,9 +729,11 @@ static int validate_change(const struct cpuset *cur, const struct cpuset *trial)
 	}
 	}
 
 
 	/* Remaining checks don't apply to root cpuset */
 	/* Remaining checks don't apply to root cpuset */
-	if ((par = cur->parent) == NULL)
+	if (cur == &top_cpuset)
 		return 0;
 		return 0;
 
 
+	par = cur->parent;
+
 	/* We must be a subset of our parent cpuset */
 	/* We must be a subset of our parent cpuset */
 	if (!is_cpuset_subset(trial, par))
 	if (!is_cpuset_subset(trial, par))
 		return -EACCES;
 		return -EACCES;
@@ -1060,10 +1062,7 @@ static int update_flag(cpuset_flagbits_t bit, struct cpuset *cs, char *buf)
 	cpu_exclusive_changed =
 	cpu_exclusive_changed =
 		(is_cpu_exclusive(cs) != is_cpu_exclusive(&trialcs));
 		(is_cpu_exclusive(cs) != is_cpu_exclusive(&trialcs));
 	mutex_lock(&callback_mutex);
 	mutex_lock(&callback_mutex);
-	if (turning_on)
-		set_bit(bit, &cs->flags);
-	else
-		clear_bit(bit, &cs->flags);
+	cs->flags = trialcs.flags;
 	mutex_unlock(&callback_mutex);
 	mutex_unlock(&callback_mutex);
 
 
 	if (cpu_exclusive_changed)
 	if (cpu_exclusive_changed)