浏览代码

checkpatch: struct seq_operations should normally be const

In the general use case struct seq_operations should be a const object.
Check for and warn where it is not.

Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Andy Whitcroft 16 年之前
父节点
当前提交
6903ffb225
共有 1 个文件被更改,包括 4 次插入3 次删除
  1. 4 3
      scripts/checkpatch.pl

+ 4 - 3
scripts/checkpatch.pl

@@ -2527,9 +2527,10 @@ sub process {
 			WARN("please use device_initcall() instead of __initcall()\n" . $herecurr);
 			WARN("please use device_initcall() instead of __initcall()\n" . $herecurr);
 		}
 		}
 # check for struct file_operations, ensure they are const.
 # check for struct file_operations, ensure they are const.
-		if ($line =~ /\bstruct\s+file_operations\b/ &&
-		    $line !~ /\bconst\b/) {
-			WARN("struct file_operations should normally be const\n" . $herecurr);
+		if ($line !~ /\bconst\b/ &&
+		    $line =~ /\bstruct\s+(file_operations|seq_operations)\b/) {
+			WARN("struct $1 should normally be const\n" .
+				$herecurr);
 		}
 		}
 
 
 # use of NR_CPUS is usually wrong
 # use of NR_CPUS is usually wrong