Browse Source

[PATCH] BUG() if setscheduler is called from interrupt context

Thomas Gleixner is adding the call to a rtmutex function in setscheduler.
This call grabs a spin_lock that is not always protected by interrupts
disabled.  So this means that setscheduler cant be called from interrupt
context.

To prevent this from happening in the future, this patch adds a
BUG_ON(in_interrupt()) in that function.  (Thanks to akpm <aka.  Andrew
Morton> for this suggestion).

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Steven Rostedt 19 years ago
parent
commit
66e5393a78
1 changed files with 2 additions and 0 deletions
  1. 2 0
      kernel/sched.c

+ 2 - 0
kernel/sched.c

@@ -3862,6 +3862,8 @@ int sched_setscheduler(struct task_struct *p, int policy,
 	unsigned long flags;
 	unsigned long flags;
 	runqueue_t *rq;
 	runqueue_t *rq;
 
 
+	/* may grab non-irq protected spin_locks */
+	BUG_ON(in_interrupt());
 recheck:
 recheck:
 	/* double check policy once rq lock held */
 	/* double check policy once rq lock held */
 	if (policy < 0)
 	if (policy < 0)