Explorar el Código

[XFRM]: xfrm_state_clone() should be static, not exported

xfrm_state_clone() is not used outside of net/xfrm/xfrm_state.c
There is no need to export it.

Spoted by sparse checker.
   CHECK   net/xfrm/xfrm_state.c
net/xfrm/xfrm_state.c:1103:19: warning: symbol 'xfrm_state_clone' was not
declared. Should it be static?

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Eric Dumazet hace 17 años
padre
commit
6666351df9
Se han modificado 1 ficheros con 1 adiciones y 2 borrados
  1. 1 2
      net/xfrm/xfrm_state.c

+ 1 - 2
net/xfrm/xfrm_state.c

@@ -1100,7 +1100,7 @@ out:
 EXPORT_SYMBOL(xfrm_state_add);
 EXPORT_SYMBOL(xfrm_state_add);
 
 
 #ifdef CONFIG_XFRM_MIGRATE
 #ifdef CONFIG_XFRM_MIGRATE
-struct xfrm_state *xfrm_state_clone(struct xfrm_state *orig, int *errp)
+static struct xfrm_state *xfrm_state_clone(struct xfrm_state *orig, int *errp)
 {
 {
 	int err = -ENOMEM;
 	int err = -ENOMEM;
 	struct xfrm_state *x = xfrm_state_alloc();
 	struct xfrm_state *x = xfrm_state_alloc();
@@ -1175,7 +1175,6 @@ struct xfrm_state *xfrm_state_clone(struct xfrm_state *orig, int *errp)
 	kfree(x);
 	kfree(x);
 	return NULL;
 	return NULL;
 }
 }
-EXPORT_SYMBOL(xfrm_state_clone);
 
 
 /* xfrm_state_lock is held */
 /* xfrm_state_lock is held */
 struct xfrm_state * xfrm_migrate_state_find(struct xfrm_migrate *m)
 struct xfrm_state * xfrm_migrate_state_find(struct xfrm_migrate *m)