소스 검색

ieee1394: add comments in struct hpsb_packet

to clarify who is supposed to set what

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Stefan Richter 18 년 전
부모
커밋
6552731a05
1개의 변경된 파일7개의 추가작업 그리고 3개의 파일을 삭제
  1. 7 3
      drivers/ieee1394/ieee1394_core.h

+ 7 - 3
drivers/ieee1394/ieee1394_core.h

@@ -37,7 +37,7 @@ struct hpsb_packet {
 		hpsb_unused, hpsb_queued, hpsb_pending, hpsb_complete
 		hpsb_unused, hpsb_queued, hpsb_pending, hpsb_complete
 	} __attribute__((packed)) state;
 	} __attribute__((packed)) state;
 
 
-	/* These are core internal. */
+	/* These are core-internal. */
 	signed char tlabel;
 	signed char tlabel;
 	signed char ack_code;
 	signed char ack_code;
 	unsigned char tcode;
 	unsigned char tcode;
@@ -62,11 +62,15 @@ struct hpsb_packet {
 	/* Store jiffies for implementing bus timeouts. */
 	/* Store jiffies for implementing bus timeouts. */
 	unsigned long sendtime;
 	unsigned long sendtime;
 
 
-	/* Sizes are in bytes. *data can be DMA-mapped. */
+	/* Core-internal.  */
 	size_t allocated_data_size;	/* as allocated */
 	size_t allocated_data_size;	/* as allocated */
+
+	/* Sizes are in bytes. To be set by caller of hpsb_alloc_packet. */
 	size_t data_size;		/* as filled in */
 	size_t data_size;		/* as filled in */
 	size_t header_size;		/* as filled in, not counting the CRC */
 	size_t header_size;		/* as filled in, not counting the CRC */
-	quadlet_t *data;
+
+	/* Buffers */
+	quadlet_t *data;		/* can be DMA-mapped */
 	quadlet_t header[5];
 	quadlet_t header[5];
 	quadlet_t embedded_data[0];	/* keep as last member */
 	quadlet_t embedded_data[0];	/* keep as last member */
 };
 };