Parcourir la source

Input: psmouse - fix input_dev leak in lifebook driver

The lifebook driver may register a second input device, but it never
unregisters it.  This fixes that.

Signed-off-by: Andres Salomon <dilinger@debian.org>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Andres Salomon il y a 17 ans
Parent
commit
653e91d01f
1 fichiers modifiés avec 6 ajouts et 1 suppressions
  1. 6 1
      drivers/input/mouse/lifebook.c

+ 6 - 1
drivers/input/mouse/lifebook.c

@@ -225,8 +225,13 @@ static void lifebook_set_resolution(struct psmouse *psmouse, unsigned int resolu
 
 
 static void lifebook_disconnect(struct psmouse *psmouse)
 static void lifebook_disconnect(struct psmouse *psmouse)
 {
 {
+	struct lifebook_data *priv = psmouse->private;
+
 	psmouse_reset(psmouse);
 	psmouse_reset(psmouse);
-	kfree(psmouse->private);
+	if (priv) {
+		input_unregister_device(priv->dev2);
+		kfree(priv);
+	}
 	psmouse->private = NULL;
 	psmouse->private = NULL;
 }
 }