浏览代码

libusual: change block scope variable to function scope

Someone changed the code to kthread and used his style instead of mine.

The problem with the block variables is that they provoke shadowing,
which is actually exactly what has happened in my other tree which
has the class patch.

Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pete Zaitcev 18 年之前
父节点
当前提交
64e35d9236
共有 1 个文件被更改,包括 2 次插入1 次删除
  1. 2 1
      drivers/usb/storage/libusual.c

+ 2 - 1
drivers/usb/storage/libusual.c

@@ -117,6 +117,7 @@ EXPORT_SYMBOL_GPL(usb_usual_check_type);
 static int usu_probe(struct usb_interface *intf,
 static int usu_probe(struct usb_interface *intf,
 			 const struct usb_device_id *id)
 			 const struct usb_device_id *id)
 {
 {
+	int rc;
 	unsigned long type;
 	unsigned long type;
 	struct task_struct* task;
 	struct task_struct* task;
 	unsigned long flags;
 	unsigned long flags;
@@ -135,7 +136,7 @@ static int usu_probe(struct usb_interface *intf,
 
 
 	task = kthread_run(usu_probe_thread, (void*)type, "libusual_%d", type);
 	task = kthread_run(usu_probe_thread, (void*)type, "libusual_%d", type);
 	if (IS_ERR(task)) {
 	if (IS_ERR(task)) {
-		int rc = PTR_ERR(task);
+		rc = PTR_ERR(task);
 		printk(KERN_WARNING "libusual: "
 		printk(KERN_WARNING "libusual: "
 		    "Unable to start the thread for %s: %d\n",
 		    "Unable to start the thread for %s: %d\n",
 		    bias_names[type], rc);
 		    bias_names[type], rc);