浏览代码

IRQ: add __must_check to request_irq

This could help to find buggy drivers where request_irq return value wasn't
checked.  There's just no reason to ignore errors which can and do occur.
Anyone who got warning during compilation have to realise what it is't
realy safe code.

Signed-off-by: Monakhov Dmitriy <dmonakhov@openvz.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Monakhov Dmitriy 18 年之前
父节点
当前提交
616883df78
共有 1 个文件被更改,包括 2 次插入2 次删除
  1. 2 2
      include/linux/interrupt.h

+ 2 - 2
include/linux/interrupt.h

@@ -83,11 +83,11 @@ struct irqaction {
 };
 };
 
 
 extern irqreturn_t no_action(int cpl, void *dev_id);
 extern irqreturn_t no_action(int cpl, void *dev_id);
-extern int request_irq(unsigned int, irq_handler_t handler,
+extern int __must_check request_irq(unsigned int, irq_handler_t handler,
 		       unsigned long, const char *, void *);
 		       unsigned long, const char *, void *);
 extern void free_irq(unsigned int, void *);
 extern void free_irq(unsigned int, void *);
 
 
-extern int devm_request_irq(struct device *dev, unsigned int irq,
+extern int __must_check devm_request_irq(struct device *dev, unsigned int irq,
 			    irq_handler_t handler, unsigned long irqflags,
 			    irq_handler_t handler, unsigned long irqflags,
 			    const char *devname, void *dev_id);
 			    const char *devname, void *dev_id);
 extern void devm_free_irq(struct device *dev, unsigned int irq, void *dev_id);
 extern void devm_free_irq(struct device *dev, unsigned int irq, void *dev_id);