浏览代码

leds/leds-s3c24xx: use devm_gpio_request

why?
because if the led_classdev_register fails we wont do gpio free
because using devm_ functions, there is no need for error paths

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
Devendra Naga 13 年之前
父节点
当前提交
5ecf6e40bb
共有 1 个文件被更改,包括 1 次插入2 次删除
  1. 1 2
      drivers/leds/leds-s3c24xx.c

+ 1 - 2
drivers/leds/leds-s3c24xx.c

@@ -65,7 +65,6 @@ static int s3c24xx_led_remove(struct platform_device *dev)
 	struct s3c24xx_gpio_led *led = pdev_to_gpio(dev);
 	struct s3c24xx_gpio_led *led = pdev_to_gpio(dev);
 
 
 	led_classdev_unregister(&led->cdev);
 	led_classdev_unregister(&led->cdev);
-	gpio_free(led->pdata->gpio);
 
 
 	return 0;
 	return 0;
 }
 }
@@ -92,7 +91,7 @@ static int s3c24xx_led_probe(struct platform_device *dev)
 
 
 	led->pdata = pdata;
 	led->pdata = pdata;
 
 
-	ret = gpio_request(pdata->gpio, "S3C24XX_LED");
+	ret = devm_gpio_request(&dev->dev, pdata->gpio, "S3C24XX_LED");
 	if (ret < 0)
 	if (ret < 0)
 		return ret;
 		return ret;