瀏覽代碼

[PATCH] locks: don't panic

Don't panic!  Just BUG_ON().

Signed-off-by: Miklos Szeredi <miklos@szeredi.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Miklos Szeredi 19 年之前
父節點
當前提交
5ce29646eb
共有 1 個文件被更改,包括 3 次插入12 次删除
  1. 3 12
      fs/locks.c

+ 3 - 12
fs/locks.c

@@ -168,18 +168,9 @@ static void locks_release_private(struct file_lock *fl)
 /* Free a lock which is not in use. */
 /* Free a lock which is not in use. */
 static void locks_free_lock(struct file_lock *fl)
 static void locks_free_lock(struct file_lock *fl)
 {
 {
-	if (fl == NULL) {
-		BUG();
-		return;
-	}
-	if (waitqueue_active(&fl->fl_wait))
-		panic("Attempting to free lock with active wait queue");
-
-	if (!list_empty(&fl->fl_block))
-		panic("Attempting to free lock with active block list");
-
-	if (!list_empty(&fl->fl_link))
-		panic("Attempting to free lock on active lock list");
+	BUG_ON(waitqueue_active(&fl->fl_wait));
+	BUG_ON(!list_empty(&fl->fl_block));
+	BUG_ON(!list_empty(&fl->fl_link));
 
 
 	locks_release_private(fl);
 	locks_release_private(fl);
 	kmem_cache_free(filelock_cache, fl);
 	kmem_cache_free(filelock_cache, fl);