Browse Source

NFSv4/NLM: Push file locking BKL dependencies down into the NLM layer

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Trond Myklebust 16 years ago
parent
commit
5cd973c44a
2 changed files with 2 additions and 6 deletions
  1. 2 0
      fs/lockd/clntproc.c
  2. 0 6
      fs/nfs/file.c

+ 2 - 0
fs/lockd/clntproc.c

@@ -165,6 +165,7 @@ int nlmclnt_proc(struct nlm_host *host, int cmd, struct file_lock *fl)
 	/* Set up the argument struct */
 	/* Set up the argument struct */
 	nlmclnt_setlockargs(call, fl);
 	nlmclnt_setlockargs(call, fl);
 
 
+	lock_kernel();
 	if (IS_SETLK(cmd) || IS_SETLKW(cmd)) {
 	if (IS_SETLK(cmd) || IS_SETLKW(cmd)) {
 		if (fl->fl_type != F_UNLCK) {
 		if (fl->fl_type != F_UNLCK) {
 			call->a_args.block = IS_SETLKW(cmd) ? 1 : 0;
 			call->a_args.block = IS_SETLKW(cmd) ? 1 : 0;
@@ -178,6 +179,7 @@ int nlmclnt_proc(struct nlm_host *host, int cmd, struct file_lock *fl)
 
 
 	fl->fl_ops->fl_release_private(fl);
 	fl->fl_ops->fl_release_private(fl);
 	fl->fl_ops = NULL;
 	fl->fl_ops = NULL;
+	unlock_kernel();
 
 
 	dprintk("lockd: clnt proc returns %d\n", status);
 	dprintk("lockd: clnt proc returns %d\n", status);
 	return status;
 	return status;

+ 0 - 6
fs/nfs/file.c

@@ -592,7 +592,6 @@ static int do_getlk(struct file *filp, int cmd, struct file_lock *fl)
 	struct inode *inode = filp->f_mapping->host;
 	struct inode *inode = filp->f_mapping->host;
 	int status = 0;
 	int status = 0;
 
 
-	lock_kernel();
 	/* Try local locking first */
 	/* Try local locking first */
 	posix_test_lock(filp, fl);
 	posix_test_lock(filp, fl);
 	if (fl->fl_type != F_UNLCK) {
 	if (fl->fl_type != F_UNLCK) {
@@ -608,7 +607,6 @@ static int do_getlk(struct file *filp, int cmd, struct file_lock *fl)
 
 
 	status = NFS_PROTO(inode)->lock(filp, cmd, fl);
 	status = NFS_PROTO(inode)->lock(filp, cmd, fl);
 out:
 out:
-	unlock_kernel();
 	return status;
 	return status;
 out_noconflict:
 out_noconflict:
 	fl->fl_type = F_UNLCK;
 	fl->fl_type = F_UNLCK;
@@ -650,13 +648,11 @@ static int do_unlk(struct file *filp, int cmd, struct file_lock *fl)
 	 * 	If we're signalled while cleaning up locks on process exit, we
 	 * 	If we're signalled while cleaning up locks on process exit, we
 	 * 	still need to complete the unlock.
 	 * 	still need to complete the unlock.
 	 */
 	 */
-	lock_kernel();
 	/* Use local locking if mounted with "-onolock" */
 	/* Use local locking if mounted with "-onolock" */
 	if (!(NFS_SERVER(inode)->flags & NFS_MOUNT_NONLM))
 	if (!(NFS_SERVER(inode)->flags & NFS_MOUNT_NONLM))
 		status = NFS_PROTO(inode)->lock(filp, cmd, fl);
 		status = NFS_PROTO(inode)->lock(filp, cmd, fl);
 	else
 	else
 		status = do_vfs_lock(filp, fl);
 		status = do_vfs_lock(filp, fl);
-	unlock_kernel();
 	return status;
 	return status;
 }
 }
 
 
@@ -673,13 +669,11 @@ static int do_setlk(struct file *filp, int cmd, struct file_lock *fl)
 	if (status != 0)
 	if (status != 0)
 		goto out;
 		goto out;
 
 
-	lock_kernel();
 	/* Use local locking if mounted with "-onolock" */
 	/* Use local locking if mounted with "-onolock" */
 	if (!(NFS_SERVER(inode)->flags & NFS_MOUNT_NONLM))
 	if (!(NFS_SERVER(inode)->flags & NFS_MOUNT_NONLM))
 		status = NFS_PROTO(inode)->lock(filp, cmd, fl);
 		status = NFS_PROTO(inode)->lock(filp, cmd, fl);
 	else
 	else
 		status = do_vfs_lock(filp, fl);
 		status = do_vfs_lock(filp, fl);
-	unlock_kernel();
 	if (status < 0)
 	if (status < 0)
 		goto out;
 		goto out;
 	/*
 	/*