xfs:xfs_dir2_node.c: pointer use before check for null · 5bf1f439c8 - Gogs

xfs:xfs_dir2_node.c: pointer use before check for null

ASSERT on args takes place after args dereference.
This assertion is redundant since we are going to panic anyway.

Found by Linux Driver Verification project (linuxtesting.org) -
PVS-Studio analyzer.

Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>

Denis Efremov 11 years ago

parent

ad22c7a043

commit

5bf1f439c8

1 changed files with 0 additions and 1 deletions

Split View Show Diff Stats

						
							+ 0
							
							- 1
						
fs/xfs/xfs_dir2_node.c
							 
								View File
							
				@@ -1327,7 +1327,6 @@ xfs_dir2_leafn_split(
			
				 	args = state->args;
			
				 	dp = args->dp;
			
				 	mp = dp->i_mount;
			
				-	ASSERT(args != NULL);
			
				 	ASSERT(oldblk->magic == XFS_DIR2_LEAFN_MAGIC);
			
				 	error = xfs_da_grow_inode(args, &blkno);
			
				 	if (error) {