tracing: fix ref count in splice pages · 5beae6efd1 - Gogs

tracing: fix ref count in splice pages

The pages allocated for the splice binary buffer did not initialize
the ref count correctly. This caused pages not to be freed and causes
a drastic memory leak.

Thanks to logdev I was able to trace the tracer to find where the leak
was.

[ Impact: stop memory leak when using splice ]

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

Steven Rostedt 16 years ago

parent

cd891ae030

commit

5beae6efd1

1 changed files with 1 additions and 0 deletions

Split View Show Diff Stats

						
							+ 1
							
							- 0
						
kernel/trace/trace.c
							 
								View File
							
				@@ -3531,6 +3531,7 @@ tracing_buffers_splice_read(struct file *file, loff_t *ppos,
			
				 		if (!ref)
			
				 			break;
			
				+		ref->ref = 1;
			
				 		ref->buffer = info->tr->buffer;
			
				 		ref->page = ring_buffer_alloc_read_page(ref->buffer);
			
				 		if (!ref->page) {