浏览代码

Btrfs: fix return code in drop_objectid_items

So dpkg fsync()'s the file and the directory containing the file whenever it
writes to a file which is really slow in btrfs.  This is partly because
fsync()'ing a directory _always_ committed the transaction instead of just
going to the tree log.  This is because drop_objectid_items() would return 1
since it does a btrfs_search_slot() which returns 1.  In tree-log jargon
this means that we have to commit the transaction to be safe.  So just check
if ret is greater than 0 and set it to 0 if it does.  With this patch we now
use the tree-log instead of committing the entire transaction, which is
twice as fast on my box.  Thanks,

Signed-off-by: Josef Bacik <josef@redhat.com>
Josef Bacik 13 年之前
父节点
当前提交
5bdbeb2187
共有 1 个文件被更改,包括 2 次插入0 次删除
  1. 2 0
      fs/btrfs/tree-log.c

+ 2 - 0
fs/btrfs/tree-log.c

@@ -2667,6 +2667,8 @@ static int drop_objectid_items(struct btrfs_trans_handle *trans,
 		btrfs_release_path(path);
 		btrfs_release_path(path);
 	}
 	}
 	btrfs_release_path(path);
 	btrfs_release_path(path);
+	if (ret > 0)
+		ret = 0;
 	return ret;
 	return ret;
 }
 }