浏览代码

fix the treatment of jfs special inodes

We used to put them on a single list, without any locking.  Racy.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Al Viro 16 年之前
父节点
当前提交
5b45d96bf9
共有 1 个文件被更改,包括 7 次插入3 次删除
  1. 7 3
      fs/jfs/jfs_imap.c

+ 7 - 3
fs/jfs/jfs_imap.c

@@ -58,9 +58,9 @@
 
 
 /*
 /*
  * __mark_inode_dirty expects inodes to be hashed.  Since we don't want
  * __mark_inode_dirty expects inodes to be hashed.  Since we don't want
- * special inodes in the fileset inode space, we hash them to a dummy head
+ * special inodes in the fileset inode space, we make them appear hashed,
+ * but do not put on any lists.
  */
  */
-static HLIST_HEAD(aggregate_hash);
 
 
 /*
 /*
  * imap locks
  * imap locks
@@ -496,7 +496,11 @@ struct inode *diReadSpecial(struct super_block *sb, ino_t inum, int secondary)
 	/* release the page */
 	/* release the page */
 	release_metapage(mp);
 	release_metapage(mp);
 
 
-	hlist_add_head(&ip->i_hash, &aggregate_hash);
+	/*
+	 * that will look hashed, but won't be on any list; hlist_del()
+	 * will work fine and require no locking.
+	 */
+	ip->i_hash.pprev = &ip->i_hash.next;
 
 
 	return (ip);
 	return (ip);
 }
 }