Browse Source

IPoIB: Don't attempt to release resources on error flow

If the ipoib client info isn't found on the _remove_one callback, we
must not attempt to scan the returned null list.  Found by Coverity.

Signed-off-by: Itai Garbi <igarbi@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Itai Garbi 12 years ago
parent
commit
5a2815f03c
1 changed files with 2 additions and 0 deletions
  1. 2 0
      drivers/infiniband/ulp/ipoib/ipoib_main.c

+ 2 - 0
drivers/infiniband/ulp/ipoib/ipoib_main.c

@@ -1693,6 +1693,8 @@ static void ipoib_remove_one(struct ib_device *device)
 		return;
 
 	dev_list = ib_get_client_data(device, &ipoib_client);
+	if (!dev_list)
+		return;
 
 	list_for_each_entry_safe(priv, tmp, dev_list, list) {
 		ib_unregister_event_handler(&priv->event_handler);