Browse Source

[PATCH] tpm: fix memory leak

The eventname was kmalloc'd and not freed in the *_show functions.

This bug was found by Coverity.

Signed-off-by: Kylene Hall <kjhall@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Kylene Jo Hall 19 years ago
parent
commit
59e89f3a09
1 changed files with 2 additions and 0 deletions
  1. 2 0
      drivers/char/tpm/tpm_bios.c

+ 2 - 0
drivers/char/tpm/tpm_bios.c

@@ -306,6 +306,7 @@ static int tpm_binary_bios_measurements_show(struct seq_file *m, void *v)
 	/* 5th: delimiter */
 	/* 5th: delimiter */
 	seq_putc(m, '\0');
 	seq_putc(m, '\0');
 
 
+	kfree(eventname);
 	return 0;
 	return 0;
 }
 }
 
 
@@ -353,6 +354,7 @@ static int tpm_ascii_bios_measurements_show(struct seq_file *m, void *v)
 	/* 4th: eventname <= max + \'0' delimiter */
 	/* 4th: eventname <= max + \'0' delimiter */
 	seq_printf(m, " %s\n", eventname);
 	seq_printf(m, " %s\n", eventname);
 
 
+	kfree(eventname);
 	return 0;
 	return 0;
 }
 }