Browse Source

Merge branch 'upstream-fixes' of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev

* 'upstream-fixes' of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev:
  [PATCH] ahci: fix NULL pointer dereference detected by Coverity
Linus Torvalds 19 years ago
parent
commit
57ddd5c180
1 changed files with 4 additions and 10 deletions
  1. 4 10
      drivers/scsi/ahci.c

+ 4 - 10
drivers/scsi/ahci.c

@@ -742,23 +742,17 @@ static irqreturn_t ahci_interrupt (int irq, void *dev_instance, struct pt_regs *
 			struct ata_queued_cmd *qc;
 			struct ata_queued_cmd *qc;
 			qc = ata_qc_from_tag(ap, ap->active_tag);
 			qc = ata_qc_from_tag(ap, ap->active_tag);
 			if (!ahci_host_intr(ap, qc))
 			if (!ahci_host_intr(ap, qc))
-				if (ata_ratelimit()) {
-					struct pci_dev *pdev =
-						to_pci_dev(ap->host_set->dev);
-					dev_printk(KERN_WARNING, &pdev->dev,
+				if (ata_ratelimit())
+					dev_printk(KERN_WARNING, host_set->dev,
 					  "unhandled interrupt on port %u\n",
 					  "unhandled interrupt on port %u\n",
 					  i);
 					  i);
-				}
 
 
 			VPRINTK("port %u\n", i);
 			VPRINTK("port %u\n", i);
 		} else {
 		} else {
 			VPRINTK("port %u (no irq)\n", i);
 			VPRINTK("port %u (no irq)\n", i);
-			if (ata_ratelimit()) {
-				struct pci_dev *pdev =
-					to_pci_dev(ap->host_set->dev);
-				dev_printk(KERN_WARNING, &pdev->dev,
+			if (ata_ratelimit())
+				dev_printk(KERN_WARNING, host_set->dev,
 					"interrupt on disabled port %u\n", i);
 					"interrupt on disabled port %u\n", i);
-			}
 		}
 		}
 
 
 		irq_ack |= (1 << i);
 		irq_ack |= (1 << i);