Browse Source

be2net: call napi_disable() for all event queues

The recent be2net commit 6384a4d (adds a support for busy polling)
introduces a regression that results in kernel crash. It incorrectly
modified be_close() so napi_disable() is called only for the first queue.
This breaks a correct pairing of napi_enable/_disable for the rest
of event queues and causes a crash in subsequent be_open() call.

Cc: Sathya Perla <sathya.perla@emulex.com>
Cc: Subbu Seetharaman <subbu.seetharaman@emulex.com>
Cc: Ajit Khaparde <ajit.khaparde@emulex.com>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Acked-by: Ajit Khaparde <ajit.khaparde@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Ivan Vecera 11 years ago
parent
commit
55485e7b41
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/net/ethernet/emulex/benet/be_main.c

+ 1 - 1
drivers/net/ethernet/emulex/benet/be_main.c

@@ -2663,8 +2663,8 @@ static int be_close(struct net_device *netdev)
 			napi_disable(&eqo->napi);
 			napi_disable(&eqo->napi);
 			be_disable_busy_poll(eqo);
 			be_disable_busy_poll(eqo);
 		}
 		}
-		adapter->flags &= ~BE_FLAGS_NAPI_ENABLED;
 	}
 	}
+	adapter->flags &= ~BE_FLAGS_NAPI_ENABLED;
 
 
 	be_async_mcc_disable(adapter);
 	be_async_mcc_disable(adapter);