Просмотр исходного кода

ALSA: asihpi - Simplify dsp code close.

dsp_code struct is not created if firmware is invalid, so check
and zero of firmware pointer is not necessary

Signed-off-by: Eliot Blennerhassett <eblennerhassett@audioscience.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Eliot Blennerhassett 13 лет назад
Родитель
Сommit
50d5f773ec
1 измененных файлов с 2 добавлено и 5 удалено
  1. 2 5
      sound/pci/asihpi/hpidspcd.c

+ 2 - 5
sound/pci/asihpi/hpidspcd.c

@@ -109,11 +109,8 @@ error1:
 /*-------------------------------------------------------------------*/
 /*-------------------------------------------------------------------*/
 void hpi_dsp_code_close(struct dsp_code *dsp_code)
 void hpi_dsp_code_close(struct dsp_code *dsp_code)
 {
 {
-	if (dsp_code->pvt->firmware) {
-		HPI_DEBUG_LOG(DEBUG, "dsp code closed\n");
-		release_firmware(dsp_code->pvt->firmware);
-		dsp_code->pvt->firmware = NULL;
-	}
+	HPI_DEBUG_LOG(DEBUG, "dsp code closed\n");
+	release_firmware(dsp_code->pvt->firmware);
 	kfree(dsp_code->pvt);
 	kfree(dsp_code->pvt);
 }
 }