浏览代码

sysfs: kill unnecessary NULL pointer check in sysfs_release()

In sysfs_release(), sysfs_buffer pointed to by filp->private_data is
guaranteed to exist.  Kill the unnecessary NULL check.  This also
makes the code more consistent with the counterpart in fs/sysfs/bin.c.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Tejun Heo 18 年之前
父节点
当前提交
50ab1a7286
共有 1 个文件被更改,包括 4 次插入5 次删除
  1. 4 5
      fs/sysfs/file.c

+ 4 - 5
fs/sysfs/file.c

@@ -311,11 +311,10 @@ static int sysfs_release(struct inode * inode, struct file * filp)
 {
 {
 	struct sysfs_buffer *buffer = filp->private_data;
 	struct sysfs_buffer *buffer = filp->private_data;
 
 
-	if (buffer) {
-		if (buffer->page)
-			free_page((unsigned long)buffer->page);
-		kfree(buffer);
-	}
+	if (buffer->page)
+		free_page((unsigned long)buffer->page);
+	kfree(buffer);
+
 	return 0;
 	return 0;
 }
 }