Browse Source

mmc: core: use non-reentrant workqueue for clock gating

The default multithread workqueue can cause the same work to be executed
concurrently on a different CPUs. This isn't really suitable for clock
gating as it might already gated the clock and gating it twice results both
host->clk_old and host->ios.clock to be set to 0.

To prevent this from happening we use system_nrt_wq instead.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Tested-by: Chris Ball <cjb@laptop.org>
Cc: <stable@kernel.org>
Signed-off-by: Chris Ball <cjb@laptop.org>
Mika Westerberg 14 years ago
parent
commit
50a50f9248
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/mmc/core/host.c

+ 1 - 1
drivers/mmc/core/host.c

@@ -179,7 +179,7 @@ void mmc_host_clk_release(struct mmc_host *host)
 	host->clk_requests--;
 	host->clk_requests--;
 	if (mmc_host_may_gate_card(host->card) &&
 	if (mmc_host_may_gate_card(host->card) &&
 	    !host->clk_requests)
 	    !host->clk_requests)
-		schedule_work(&host->clk_gate_work);
+		queue_work(system_nrt_wq, &host->clk_gate_work);
 	spin_unlock_irqrestore(&host->clk_lock, flags);
 	spin_unlock_irqrestore(&host->clk_lock, flags);
 }
 }