Browse Source

[PATCH] oom: kthread infinite loop fix

Skip kernel threads, rather than having them return 0 from badness.
Theoretically, badness might truncate all results to 0, thus a kernel thread
might be picked first, causing an infinite loop.

Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Nick Piggin 18 years ago
parent
commit
5081dde33f
1 changed files with 3 additions and 0 deletions
  1. 3 0
      mm/oom_kill.c

+ 3 - 0
mm/oom_kill.c

@@ -207,6 +207,9 @@ static struct task_struct *select_bad_process(unsigned long *ppoints)
 		unsigned long points;
 		unsigned long points;
 		int releasing;
 		int releasing;
 
 
+		/* skip kernel threads */
+		if (!p->mm)
+			continue;
 		/* skip the init task with pid == 1 */
 		/* skip the init task with pid == 1 */
 		if (p->pid == 1)
 		if (p->pid == 1)
 			continue;
 			continue;