浏览代码

Staging: comedi: s626: Possible read buffer overflow fix

If `cmd->chanlist_len' is 0, then we write ppl[-1].

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roel Kluin 16 年之前
父节点
当前提交
4ff863b1db
共有 1 个文件被更改,包括 2 次插入1 次删除
  1. 2 1
      drivers/staging/comedi/drivers/s626.c

+ 2 - 1
drivers/staging/comedi/drivers/s626.c

@@ -1707,7 +1707,8 @@ static int s626_ai_load_polllist(uint8_t * ppl, struct comedi_cmd *cmd)
 		else
 			ppl[n] = (CR_CHAN((cmd->chanlist)[n])) | (RANGE_10V);
 	}
-	ppl[n - 1] |= EOPL;
+	if (n != 0)
+		ppl[n - 1] |= EOPL;
 
 	return n;
 }