Эх сурвалжийг харах

firewire: Survive more than 256 bus resets

The "color" is used during the topology building after a bus reset,
hovever in "struct fw_node"s it is stored in a u8, but in struct fw_card
it is stored in an int.  When the value wraps in one struct, but not
the other, disaster strikes.

Signed-off-by: Jay Fenlason <fenlason@redhat.com>

Fixes http://bugzilla.kernel.org/show_bug.cgi?id=10922.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Jay Fenlason 16 жил өмнө
parent
commit
4f9740d4f5

+ 1 - 1
drivers/firewire/fw-transaction.h

@@ -248,7 +248,7 @@ struct fw_card {
 	struct fw_node *local_node;
 	struct fw_node *local_node;
 	struct fw_node *root_node;
 	struct fw_node *root_node;
 	struct fw_node *irm_node;
 	struct fw_node *irm_node;
-	int color;
+	u8 color; /* must be u8 to match the definition in struct fw_node */
 	int gap_count;
 	int gap_count;
 	bool beta_repeaters_present;
 	bool beta_repeaters_present;