Quellcode durchsuchen

Btrfs: avoid null deref in unpin_extent_cache()

I re-orderred the checks to avoid dereferencing "em" if it was null.

Found by smatch static checker.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Chris Mason <chris.mason@oracle.com>
Dan Carpenter vor 15 Jahren
Ursprung
Commit
4eb3991c5d
1 geänderte Dateien mit 1 neuen und 1 gelöschten Zeilen
  1. 1 1
      fs/btrfs/extent_map.c

+ 1 - 1
fs/btrfs/extent_map.c

@@ -208,7 +208,7 @@ int unpin_extent_cache(struct extent_map_tree *tree, u64 start, u64 len)
 	write_lock(&tree->lock);
 	em = lookup_extent_mapping(tree, start, len);
 
-	WARN_ON(em->start != start || !em);
+	WARN_ON(!em || em->start != start);
 
 	if (!em)
 		goto out;