Jelajahi Sumber

infiniband: Stop using NLA_PUT*().

These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.

Signed-off-by: David S. Miller <davem@davemloft.net>
David S. Miller 13 tahun lalu
induk
melakukan
4e24ffa4d9
1 mengubah file dengan 2 tambahan dan 1 penghapusan
  1. 2 1
      drivers/infiniband/core/netlink.c

+ 2 - 1
drivers/infiniband/core/netlink.c

@@ -125,7 +125,8 @@ int ibnl_put_attr(struct sk_buff *skb, struct nlmsghdr *nlh,
 	unsigned char *prev_tail;
 
 	prev_tail = skb_tail_pointer(skb);
-	NLA_PUT(skb, type, len, data);
+	if (nla_put(skb, type, len, data))
+		goto nla_put_failure;
 	nlh->nlmsg_len += skb_tail_pointer(skb) - prev_tail;
 	return 0;