Эх сурвалжийг харах

sunrpc: Propagate errors from xs_bind() through xs_create_sock()

xs_create_sock() is supposed to return a pointer or an ERR_PTR-encoded
error, but it currently returns 0 if xs_bind() fails.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Cc: stable@kernel.org [v2.6.37]
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Ben Hutchings 14 жил өмнө
parent
commit
4cea288aaf

+ 2 - 1
net/sunrpc/xprtsock.c

@@ -1631,7 +1631,8 @@ static struct socket *xs_create_sock(struct rpc_xprt *xprt,
 	}
 	}
 	xs_reclassify_socket(family, sock);
 	xs_reclassify_socket(family, sock);
 
 
-	if (xs_bind(transport, sock)) {
+	err = xs_bind(transport, sock);
+	if (err) {
 		sock_release(sock);
 		sock_release(sock);
 		goto out;
 		goto out;
 	}
 	}