فهرست منبع

bridge: netfilter: fix a memory leak

nf_bridge_alloc() always reset the skb->nf_bridge, so we should always
put the old one.

Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Signed-off-by: Bart De Schuymer <bdschuym@pandora.be>
Signed-off-by: David S. Miller <davem@davemloft.net>
Changli Gao 15 سال پیش
والد
کامیت
4c3a76abd3
1فایلهای تغییر یافته به همراه1 افزوده شده و 1 حذف شده
  1. 1 1
      net/bridge/br_netfilter.c

+ 1 - 1
net/bridge/br_netfilter.c

@@ -162,8 +162,8 @@ static inline struct nf_bridge_info *nf_bridge_unshare(struct sk_buff *skb)
 		if (tmp) {
 		if (tmp) {
 			memcpy(tmp, nf_bridge, sizeof(struct nf_bridge_info));
 			memcpy(tmp, nf_bridge, sizeof(struct nf_bridge_info));
 			atomic_set(&tmp->use, 1);
 			atomic_set(&tmp->use, 1);
-			nf_bridge_put(nf_bridge);
 		}
 		}
+		nf_bridge_put(nf_bridge);
 		nf_bridge = tmp;
 		nf_bridge = tmp;
 	}
 	}
 	return nf_bridge;
 	return nf_bridge;