Browse Source

IPv6: datagram_send_ctl() should exit immediately when an error occured

When an error occured, datagram_send_ctl() should exit immediately rather than
continue to run the for loop. Otherwise, the variable err might be changed and
the error might be hidden.

Fix this bug by using "goto" instead of "break".

Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Miao Xie 17 years ago
parent
commit
4a36702e01
1 changed files with 1 additions and 1 deletions
  1. 1 1
      net/ipv6/datagram.c

+ 1 - 1
net/ipv6/datagram.c

@@ -732,7 +732,7 @@ int datagram_send_ctl(struct net *net,
 			LIMIT_NETDEBUG(KERN_DEBUG "invalid cmsg type: %d\n",
 			LIMIT_NETDEBUG(KERN_DEBUG "invalid cmsg type: %d\n",
 				       cmsg->cmsg_type);
 				       cmsg->cmsg_type);
 			err = -EINVAL;
 			err = -EINVAL;
-			break;
+			goto exit_f;
 		}
 		}
 	}
 	}