Browse Source

viafb: get rid of i2c debug cruft

It's ugly and adds a global.h dependency.

Cc: ScottFang@viatech.com.cn
Cc: JosephChan@via.com.tw
Cc: Harald Welte <laforge@gnumonks.org>
Acked-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Jonathan Corbet 15 years ago
parent
commit
4a28ea9ced
1 changed files with 2 additions and 4 deletions
  1. 2 4
      drivers/video/via/via_i2c.c

+ 2 - 4
drivers/video/via/via_i2c.c

@@ -52,7 +52,7 @@ static void via_i2c_setscl(void *data, int state)
 		val |= 0x80;
 		val |= 0x80;
 		break;
 		break;
 	default:
 	default:
-		DEBUG_MSG("viafb_i2c: specify wrong i2c type.\n");
+		printk(KERN_ERR "viafb_i2c: specify wrong i2c type.\n");
 	}
 	}
 	via_write_reg(adap_data->io_port, adap_data->ioport_index, val);
 	via_write_reg(adap_data->io_port, adap_data->ioport_index, val);
 	spin_unlock_irqrestore(&i2c_vdev->reg_lock, flags);
 	spin_unlock_irqrestore(&i2c_vdev->reg_lock, flags);
@@ -104,7 +104,7 @@ static void via_i2c_setsda(void *data, int state)
 		val |= 0x40;
 		val |= 0x40;
 		break;
 		break;
 	default:
 	default:
-		DEBUG_MSG("viafb_i2c: specify wrong i2c type.\n");
+		printk(KERN_ERR "viafb_i2c: specify wrong i2c type.\n");
 	}
 	}
 	via_write_reg(adap_data->io_port, adap_data->ioport_index, val);
 	via_write_reg(adap_data->io_port, adap_data->ioport_index, val);
 	spin_unlock_irqrestore(&i2c_vdev->reg_lock, flags);
 	spin_unlock_irqrestore(&i2c_vdev->reg_lock, flags);
@@ -175,8 +175,6 @@ static int create_i2c_bus(struct i2c_adapter *adapter,
 			  struct via_port_cfg *adap_cfg,
 			  struct via_port_cfg *adap_cfg,
 			  struct pci_dev *pdev)
 			  struct pci_dev *pdev)
 {
 {
-	DEBUG_MSG(KERN_DEBUG "viafb: creating bus adap=0x%p, algo_bit_data=0x%p, adap_cfg=0x%p\n", adapter, algo, adap_cfg);
-
 	algo->setsda = via_i2c_setsda;
 	algo->setsda = via_i2c_setsda;
 	algo->setscl = via_i2c_setscl;
 	algo->setscl = via_i2c_setscl;
 	algo->getsda = via_i2c_getsda;
 	algo->getsda = via_i2c_getsda;