Sfoglia il codice sorgente

[NETFILTER]: SNMP NAT: fix memleak in snmp_object_decode

If kmalloc fails, error path leaks data allocated from asn1_oid_decode().

Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Chris Wright 19 anni fa
parent
commit
4a06373913
1 ha cambiato i file con 1 aggiunte e 0 eliminazioni
  1. 1 0
      net/ipv4/netfilter/ip_nat_snmp_basic.c

+ 1 - 0
net/ipv4/netfilter/ip_nat_snmp_basic.c

@@ -768,6 +768,7 @@ static unsigned char snmp_object_decode(struct asn1_ctx *ctx,
 			len *= sizeof(unsigned long);
 			*obj = kmalloc(sizeof(struct snmp_object) + len, GFP_ATOMIC);
 			if (*obj == NULL) {
+				kfree(lp);
 				kfree(id);
 				if (net_ratelimit())
 					printk("OOM in bsalg (%d)\n", __LINE__);