Browse Source

drbd: Fix test of unsigned in _drbd_fault_random()

rsp->count is unsigned so the test does not work.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Roel Kluin 15 years ago
parent
commit
49829ea74f
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/block/drbd/drbd_main.c

+ 1 - 1
drivers/block/drbd/drbd_main.c

@@ -3623,7 +3623,7 @@ _drbd_fault_random(struct fault_random_state *rsp)
 {
 	long refresh;
 
-	if (--rsp->count < 0) {
+	if (!rsp->count--) {
 		get_random_bytes(&refresh, sizeof(refresh));
 		rsp->state += refresh;
 		rsp->count = FAULT_RANDOM_REFRESH;