Browse Source

staging: ft1000: Fix goto error logic.

Fix goto error logic which could lead to kernel panics
because kthread_stop() is called in not correct error
conditions. Seen it sometimes when dsp_reload() fails
then I got kernel panic.

Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko 14 years ago
parent
commit
4960b8fe1b
1 changed files with 2 additions and 2 deletions
  1. 2 2
      drivers/staging/ft1000/ft1000-usb/ft1000_usb.c

+ 2 - 2
drivers/staging/ft1000/ft1000-usb/ft1000_usb.c

@@ -204,9 +204,9 @@ static int ft1000_probe(struct usb_interface *interface,
 
 	return 0;
 
-err_load:
-	kthread_stop(pft1000info->pPollThread);
 err_thread:
+	kthread_stop(pft1000info->pPollThread);
+err_load:
 	kfree(pFileStart);
 err_fw:
 	kfree(ft1000dev);