Selaa lähdekoodia

mfd: arizona: Clean up on failed runtime resume

Make sure that we don't leave the device enabled needlessly.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Mark Brown 12 vuotta sitten
vanhempi
commit
4816bd1c6d
1 muutettua tiedostoa jossa 7 lisäystä ja 4 poistoa
  1. 7 4
      drivers/mfd/arizona-core.c

+ 7 - 4
drivers/mfd/arizona-core.c

@@ -235,18 +235,21 @@ static int arizona_runtime_resume(struct device *dev)
 
 	ret = arizona_wait_for_boot(arizona);
 	if (ret != 0) {
-		regulator_disable(arizona->dcvdd);
-		return ret;
+		goto err;
 	}
 
 	ret = regcache_sync(arizona->regmap);
 	if (ret != 0) {
 		dev_err(arizona->dev, "Failed to restore register cache\n");
-		regulator_disable(arizona->dcvdd);
-		return ret;
+		goto err;
 	}
 
 	return 0;
+
+err:
+	regcache_cache_only(arizona->regmap, true);
+	regulator_disable(arizona->dcvdd);
+	return ret;
 }
 
 static int arizona_runtime_suspend(struct device *dev)