Browse Source

[PATCH] off-by-1 in kernel/power/main.c

There's an off-by-1 in kernel/power/main.c:state_store() ...  if your
kernel just happens to have some non-zero data at pm_states[PM_SUSPEND_MAX]
(i.e.  one past the end of the array) then it'll let you write anything you
want to /sys/power/state and in response the box will enter S5.

Signed-off-by: dean gaudet <dean@arctic.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
dean gaudet 19 years ago
parent
commit
47bb789973
1 changed files with 1 additions and 1 deletions
  1. 1 1
      kernel/power/main.c

+ 1 - 1
kernel/power/main.c

@@ -272,7 +272,7 @@ static ssize_t state_store(struct subsystem * subsys, const char * buf, size_t n
 		if (*s && !strncmp(buf, *s, len))
 		if (*s && !strncmp(buf, *s, len))
 			break;
 			break;
 	}
 	}
-	if (*s)
+	if (state < PM_SUSPEND_MAX && *s)
 		error = enter_state(state);
 		error = enter_state(state);
 	else
 	else
 		error = -EINVAL;
 		error = -EINVAL;