Browse Source

mac80211_hwsim: fix possible race condition in usage of info->control.sta & control.vif

info->control.sta and control.vif may only be dereferenced during the
drv_tx call otherwise could lead to use-after-free bugs.

Signed-off-by: Thomas Huehn <thomas@net.t-labs.tu-berlin.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Thomas Huehn 13 years ago
parent
commit
4581d91b77
1 changed files with 0 additions and 5 deletions
  1. 0 5
      drivers/net/wireless/mac80211_hwsim.c

+ 0 - 5
drivers/net/wireless/mac80211_hwsim.c

@@ -739,11 +739,6 @@ static void mac80211_hwsim_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
 
 	txi = IEEE80211_SKB_CB(skb);
 
-	if (txi->control.vif)
-		hwsim_check_magic(txi->control.vif);
-	if (txi->control.sta)
-		hwsim_check_sta_magic(txi->control.sta);
-
 	ieee80211_tx_info_clear_status(txi);
 
 	/* frame was transmitted at most favorable rate at first attempt */