Browse Source

[NET] napi: use non-interruptible sleep in napi_disable

The current napi_disable() uses msleep_interruptible() but doesn't
(and can't) exit in case there's a signal, thus ending up doing a
hot spin without a cpu_relax. Use uninterruptible sleep instead.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Benjamin Herrenschmidt 17 years ago
parent
commit
43cc7380ec
1 changed files with 1 additions and 1 deletions
  1. 1 1
      include/linux/netdevice.h

+ 1 - 1
include/linux/netdevice.h

@@ -390,7 +390,7 @@ static inline void napi_complete(struct napi_struct *n)
 static inline void napi_disable(struct napi_struct *n)
 static inline void napi_disable(struct napi_struct *n)
 {
 {
 	while (test_and_set_bit(NAPI_STATE_SCHED, &n->state))
 	while (test_and_set_bit(NAPI_STATE_SCHED, &n->state))
-		msleep_interruptible(1);
+		msleep(1);
 }
 }
 
 
 /**
 /**