Преглед на файлове

SUNRPC: Fix memory barriers for req->rq_received

We need to ensure that all writes to the XDR buffers are done before
req->rq_received is visible to other processors.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Trond Myklebust преди 19 години
родител
ревизия
43ac3f2961
променени са 2 файла, в които са добавени 7 реда и са изтрити 1 реда
  1. 5 0
      net/sunrpc/clnt.c
  2. 2 1
      net/sunrpc/xprt.c

+ 5 - 0
net/sunrpc/clnt.c

@@ -1069,6 +1069,11 @@ call_decode(struct rpc_task *task)
 		return;
 		return;
 	}
 	}
 
 
+	/*
+	 * Ensure that we see all writes made by xprt_complete_rqst()
+	 * before it changed req->rq_received.
+	 */
+	smp_rmb();
 	req->rq_rcv_buf.len = req->rq_private_buf.len;
 	req->rq_rcv_buf.len = req->rq_private_buf.len;
 
 
 	/* Check that the softirq receive buffer is valid */
 	/* Check that the softirq receive buffer is valid */

+ 2 - 1
net/sunrpc/xprt.c

@@ -651,6 +651,8 @@ void xprt_complete_rqst(struct rpc_task *task, int copied)
 	task->tk_rtt = (long)jiffies - req->rq_xtime;
 	task->tk_rtt = (long)jiffies - req->rq_xtime;
 
 
 	list_del_init(&req->rq_list);
 	list_del_init(&req->rq_list);
+	/* Ensure all writes are done before we update req->rq_received */
+	smp_wmb();
 	req->rq_received = req->rq_private_buf.len = copied;
 	req->rq_received = req->rq_private_buf.len = copied;
 	rpc_wake_up_task(task);
 	rpc_wake_up_task(task);
 }
 }
@@ -727,7 +729,6 @@ void xprt_transmit(struct rpc_task *task)
 
 
 	dprintk("RPC: %4d xprt_transmit(%u)\n", task->tk_pid, req->rq_slen);
 	dprintk("RPC: %4d xprt_transmit(%u)\n", task->tk_pid, req->rq_slen);
 
 
-	smp_rmb();
 	if (!req->rq_received) {
 	if (!req->rq_received) {
 		if (list_empty(&req->rq_list)) {
 		if (list_empty(&req->rq_list)) {
 			spin_lock_bh(&xprt->transport_lock);
 			spin_lock_bh(&xprt->transport_lock);