Home Explore Help
Register Sign In
phyus
/
linux-vybrid_public
8
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

jbd: correctly unescape journal data blocks

Fix a long-standing typo (predating git) that will cause data corruption if a
journal data block needs unescaping.  At the moment the wrong buffer head's
data is being unescaped.

To test this case mount a filesystem with data=journal, start creating and
deleting a bunch of files containing only JFS_MAGIC_NUMBER (0xc03b3998), then
pull the plug on the device.  Without this patch the files will contain zeros
instead of the correct data after recovery.

Signed-off-by: Duane Griffin <duaneg@dghda.com>
Acked-by: Jan Kara <jack@suse.cz>
Cc: <linux-ext4@vger.kernel.org>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Duane Griffin 17 years ago
parent
44e0451db0
commit
439aeec639
1 changed files with 1 additions and 1 deletions
Unified View Show Diff Stats
  1. 1 1
      fs/jbd/recovery.c

+ 1 - 1
fs/jbd/recovery.c
View File 

@@ -478,7 +478,7 @@ static int do_one_pass(journal_t *journal,
 
 					memcpy(nbh->b_data, obh->b_data,
 
 					memcpy(nbh->b_data, obh->b_data,
 
 							journal->j_blocksize);
 
 							journal->j_blocksize);
 
 					if (flags & JFS_FLAG_ESCAPE) {
 
 					if (flags & JFS_FLAG_ESCAPE) {
 
-						*((__be32 *)bh->b_data) =
 
+						*((__be32 *)nbh->b_data) =
 
 						cpu_to_be32(JFS_MAGIC_NUMBER);
 
 						cpu_to_be32(JFS_MAGIC_NUMBER);
 
 					}
 
 					}