瀏覽代碼

[TCP]: BIC coding bug in Linux 2.6.13

Missing parenthesis in causes BIC to be slow in increasing congestion
window.

Spotted by Injong Rhee.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Stephen Hemminger 19 年之前
父節點
當前提交
42a39450f8
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1 1
      net/ipv4/tcp_bic.c

+ 1 - 1
net/ipv4/tcp_bic.c

@@ -136,7 +136,7 @@ static inline void bictcp_update(struct bictcp *ca, u32 cwnd)
 		else if (cwnd < ca->last_max_cwnd + max_increment*(BICTCP_B-1))
 		else if (cwnd < ca->last_max_cwnd + max_increment*(BICTCP_B-1))
 			/* slow start */
 			/* slow start */
 			ca->cnt = (cwnd * (BICTCP_B-1))
 			ca->cnt = (cwnd * (BICTCP_B-1))
-				/ cwnd-ca->last_max_cwnd;
+				/ (cwnd - ca->last_max_cwnd);
 		else
 		else
 			/* linear increase */
 			/* linear increase */
 			ca->cnt = cwnd / max_increment;
 			ca->cnt = cwnd / max_increment;