瀏覽代碼

V4L/DVB (8546): saa7146: fix read from uninitialized memory

The offset field of the scatterlist entry *after* the last valid scatterlist
entry was used instead of the first scatterlist entry (as was the intention
of this code).

This worked fine until the kzalloc of the sglist was replaced with kmalloc
and sg_init_table only zeroed the exact needed length. Apparently kzalloc
zeroes a bit more than is strictly necessary so the offset field was
always 0 in the past.

But now the offset field was suddenly random and this led to broken captures.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Hans Verkuil 17 年之前
父節點
當前提交
429e90893c
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1 1
      drivers/media/common/saa7146_video.c

+ 1 - 1
drivers/media/common/saa7146_video.c

@@ -656,7 +656,7 @@ static int saa7146_pgtable_build(struct saa7146_dev *dev, struct saa7146_buf *bu
 
 
 		/* if we have a user buffer, the first page may not be
 		/* if we have a user buffer, the first page may not be
 		   aligned to a page boundary. */
 		   aligned to a page boundary. */
-		pt1->offset = list->offset;
+		pt1->offset = dma->sglist->offset;
 		pt2->offset = pt1->offset+o1;
 		pt2->offset = pt1->offset+o1;
 		pt3->offset = pt1->offset+o2;
 		pt3->offset = pt1->offset+o2;