Browse Source

dcbnl: unlock on an error path in dcbnl_cee_fill()

We need to release "dcb_lock" which we took on the previous line.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Dan Carpenter 14 years ago
parent
commit
40f5d72a4f
1 changed files with 1 additions and 1 deletions
  1. 1 1
      net/dcb/dcbnl.c

+ 1 - 1
net/dcb/dcbnl.c

@@ -1409,7 +1409,7 @@ static int dcbnl_cee_fill(struct sk_buff *skb, struct net_device *netdev)
 	spin_lock(&dcb_lock);
 	spin_lock(&dcb_lock);
 	app = nla_nest_start(skb, DCB_ATTR_CEE_APP_TABLE);
 	app = nla_nest_start(skb, DCB_ATTR_CEE_APP_TABLE);
 	if (!app)
 	if (!app)
-		goto nla_put_failure;
+		goto dcb_unlock;
 
 
 	list_for_each_entry(itr, &dcb_app_list, list) {
 	list_for_each_entry(itr, &dcb_app_list, list) {
 		if (strncmp(itr->name, netdev->name, IFNAMSIZ) == 0) {
 		if (strncmp(itr->name, netdev->name, IFNAMSIZ) == 0) {