Sfoglia il codice sorgente

[ALSA] ad1848 double free

Modules: AD1848 driver

Same again, snd_ctl_add() already kfree's on error.

Coverity #956

Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Dave Jones 19 anni fa
parent
commit
3de4414e79
1 ha cambiato i file con 1 aggiunte e 3 eliminazioni
  1. 1 3
      sound/isa/ad1848/ad1848_lib.c

+ 1 - 3
sound/isa/ad1848/ad1848_lib.c

@@ -1202,10 +1202,8 @@ int snd_ad1848_add_ctl(struct snd_ad1848 *chip, const char *name, int index, int
 	strlcpy(ctl->id.name, name, sizeof(ctl->id.name));
 	ctl->id.index = index;
 	ctl->private_value = value;
-	if ((err = snd_ctl_add(chip->card, ctl)) < 0) {
-		snd_ctl_free_one(ctl);
+	if ((err = snd_ctl_add(chip->card, ctl)) < 0)
 		return err;
-	}
 	return 0;
 }