浏览代码

backlight: hp680_bl - Use platform_device_register_simple()

Use platform_device_register_simple() and also fix error
handling when platform_device_alloc() fails (hp680_bl_driver
is left registered).

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>
Akinobu Mita 16 年之前
父节点
当前提交
3bcdcc0e66
共有 1 个文件被更改,包括 8 次插入12 次删除
  1. 8 12
      drivers/video/backlight/hp680_bl.c

+ 8 - 12
drivers/video/backlight/hp680_bl.c

@@ -151,19 +151,15 @@ static int __init hp680bl_init(void)
 	int ret;
 	int ret;
 
 
 	ret = platform_driver_register(&hp680bl_driver);
 	ret = platform_driver_register(&hp680bl_driver);
-	if (!ret) {
-		hp680bl_device = platform_device_alloc("hp680-bl", -1);
-		if (!hp680bl_device)
-			return -ENOMEM;
-
-		ret = platform_device_add(hp680bl_device);
-
-		if (ret) {
-			platform_device_put(hp680bl_device);
-			platform_driver_unregister(&hp680bl_driver);
-		}
+	if (ret)
+		return ret;
+	hp680bl_device = platform_device_register_simple("hp680-bl", -1,
+							NULL, 0);
+	if (IS_ERR(hp680bl_device)) {
+		platform_driver_unregister(&hp680bl_driver);
+		return PTR_ERR(hp680bl_device);
 	}
 	}
-	return ret;
+	return 0;
 }
 }
 
 
 static void __exit hp680bl_exit(void)
 static void __exit hp680bl_exit(void)