瀏覽代碼

signals, debug: fix BUG: using smp_processor_id() in preemptible code in print_fatal_signal()

With print-fatal-signals=1 on a kernel with CONFIG_PREEMPT=y, sending an
unexpected signal to a process causes a BUG: using smp_processor_id() in
preemptible code.

get_signal_to_deliver() releases the siglock before calling
print_fatal_signal(), which calls show_regs(), which calls
smp_processor_id(), which is not supposed to be called from a
preemptible thread.

Make sure show_regs() runs with preemption disabled.

Signed-off-by: Ed Swierk <eswierk@aristanetworks.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Ed Swierk 16 年之前
父節點
當前提交
3a9f84d354
共有 1 個文件被更改,包括 2 次插入0 次删除
  1. 2 0
      kernel/signal.c

+ 2 - 0
kernel/signal.c

@@ -909,7 +909,9 @@ static void print_fatal_signal(struct pt_regs *regs, int signr)
 	}
 	}
 #endif
 #endif
 	printk("\n");
 	printk("\n");
+	preempt_disable();
 	show_regs(regs);
 	show_regs(regs);
+	preempt_enable();
 }
 }
 
 
 static int __init setup_print_fatal_signals(char *str)
 static int __init setup_print_fatal_signals(char *str)