Explorar o código

[SCTP] bug: sctp_assoc_lookup_laddr() is broken with ipv6.

It expects (and gets) laddr with net-endian sin_port.  And then it calls
sctp_bind_addr_match(), which *does* care about port numbers in case of
ipv6 and expects them to be host-endian.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Al Viro %!s(int64=18) %!d(string=hai) anos
pai
achega
39940a48c4
Modificáronse 1 ficheiros con 3 adicións e 1 borrados
  1. 3 1
      net/sctp/associola.c

+ 3 - 1
net/sctp/associola.c

@@ -1335,10 +1335,12 @@ int sctp_assoc_lookup_laddr(struct sctp_association *asoc,
 			    const union sctp_addr *laddr)
 {
 	int found;
+	union sctp_addr tmp;
 
+	flip_to_h(&tmp, laddr);
 	sctp_read_lock(&asoc->base.addr_lock);
 	if ((asoc->base.bind_addr.port == ntohs(laddr->v4.sin_port)) &&
-	    sctp_bind_addr_match(&asoc->base.bind_addr, laddr,
+	    sctp_bind_addr_match(&asoc->base.bind_addr, &tmp,
 			         sctp_sk(asoc->base.sk))) {
 		found = 1;
 		goto out;