浏览代码

[PATCH] ipmi: fix uninitialized data bug

gcc issues the following warning:

drivers/char/ipmi/ipmi_si_intf.c: In function ‘init_ipmi_si’:
drivers/char/ipmi/ipmi_si_intf.c:1729: warning: ‘data.irq’ may be used uninitialized in this function

This is indeed a bug.  data.irq is completely uninitialized in some code
paths.  Worse than that, data from a previous decode_dmi() run can easily
leak through successive calls.

Signed-off-by: Jeff Garzik <jeff@garzik.org>
Acked-by: Corey Minyard <minyard@acm.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Jeff Garzik 18 年之前
父节点
当前提交
397f4ebf4f
共有 1 个文件被更改,包括 1 次插入0 次删除
  1. 1 0
      drivers/char/ipmi/ipmi_si_intf.c

+ 1 - 0
drivers/char/ipmi/ipmi_si_intf.c

@@ -1734,6 +1734,7 @@ static void __devinit dmi_find_bmc(void)
 	int                  rv;
 	int                  rv;
 
 
 	while ((dev = dmi_find_device(DMI_DEV_TYPE_IPMI, NULL, dev))) {
 	while ((dev = dmi_find_device(DMI_DEV_TYPE_IPMI, NULL, dev))) {
+		memset(&data, 0, sizeof(data));
 		rv = decode_dmi((struct dmi_header *) dev->device_data, &data);
 		rv = decode_dmi((struct dmi_header *) dev->device_data, &data);
 		if (!rv)
 		if (!rv)
 			try_init_dmi(&data);
 			try_init_dmi(&data);